Issue 6028 - vlv index keys inconsistencies #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progier389
changed the title
droideck
approved these changes
Jan 11, 2024
| @@ -157,6 +157,7 @@ int dbmdb_run_ldif2db(Slapi_PBlock *pb); | |||
|
|
|||
|
|
|||
| /* mdb_import_threads.c */ | |||
| const char *attr_in_list(const char *search, char **list); | |||
There was a problem hiding this comment.
This line seems to be unrelated to the change (and not mentioned in the commit message). Is it here by mistake or do I miss something?
There was a problem hiding this comment.
You are right: this is a left over of a previous attempt that was using attr_in_list instead of is_reindex attr
I will remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that reindexed vlv database are not cleared, so old keys remains
Solution: truncate the reindexed vlv sub database and its cache before starting the import engine.
Note: this is tested by: dirsrvtests/tests/suites/vlv/regression_test.py::test_vlv_cache_subdb_names CI test
Issue #6028
Reviewed by: @droideck (Thanks!)